Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4607 : [Developer Video] How to use an Accessibility Scanner? #5129

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Fix #4607 : [Developer Video] How to use an Accessibility Scanner? #5129

merged 5 commits into from
Aug 14, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Aug 9, 2023 •
edited
Loading

Explanation

Fix #4607 : [Developer Video] How to use an Accessibility Scanner?

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@MohitGupta121 MohitGupta121 requested a review from a team as a code owner August 9, 2023 18:03
@MohitGupta121 MohitGupta121 requested review from a team as code owners August 9, 2023 18:03
@MohitGupta121 MohitGupta121 removed the request for review from kkmurerwa August 9, 2023 18:04
MohitGupta121
MohitGupta121 commented Aug 9, 2023
View reviewed changes
Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkmurerwa @adhiamboperes PTAL, please give first pass to this video and wiki changes. Thanks!

adhiamboperes
adhiamboperes requested changes Aug 10, 2023
View reviewed changes
wiki/Accessibility-A11y-Guide.md Outdated Show resolved Hide resolved
wiki/Accessibility-A11y-Guide.md Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Aug 10, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented Aug 10, 2023

Hi @MohitGupta121, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@MohitGupta121
Copy link
Member Author

@adhiamboperes PTAL, I mentioned in both places. Thanks!

adhiamboperes
adhiamboperes requested changes Aug 11, 2023
View reviewed changes
wiki/Accessibility-A11y-Guide.md Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Aug 11, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented Aug 11, 2023

Hi @MohitGupta121, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@MohitGupta121
Copy link
Member Author

@adhiamboperes PTAL, Thanks!

adhiamboperes
adhiamboperes approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121!

This LGTM.

@oppiabot
Copy link

oppiabot bot commented Aug 14, 2023

Unassigning @adhiamboperes since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Aug 14, 2023

Assigning @seanlip for code owner reviews. Thanks!

@seanlip seanlip merged commit d74576d into oppia:develop Aug 14, 2023
25 checks passed
@seanlip
Copy link
Member

seanlip commented Aug 14, 2023

Thanks @MohitGupta121 ! Merged.

@MohitGupta121 MohitGupta121 deleted the accessiblity_video branch August 14, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

@adhiamboperes adhiamboperes adhiamboperes approved these changes

Assignees

@seanlip seanlip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Developer Video] How to use an Accessibility Scanner?
4 participants
@MohitGupta121 @seanlip @adhiamboperes @kkmurerwa